Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development v0.2.0 #17

Merged
merged 17 commits into from
Oct 20, 2024
Merged

Development v0.2.0 #17

merged 17 commits into from
Oct 20, 2024

Conversation

0xHueristiq
Copy link
Contributor

No description provided.

dependabot bot and others added 17 commits September 4, 2023 14:22
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4 to 5.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](goreleaser/goreleaser-action@v4...v5)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/chromedp/chromedp](https://github.com/chromedp/chromedp) from 0.9.1 to 0.9.3.
- [Release notes](https://github.com/chromedp/chromedp/releases)
- [Commits](chromedp/chromedp@v0.9.1...v0.9.3)

---
updated-dependencies:
- dependency-name: github.com/chromedp/chromedp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…tions/checkout-4

chore(deps): bump actions/checkout from 3 to 4
…releaser/goreleaser-action-5

chore(deps): bump goreleaser/goreleaser-action from 4 to 5
….com/chromedp/chromedp-0.9.3

chore(deps): bump github.com/chromedp/chromedp from 0.9.1 to 0.9.3
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…ctions/setup-go-5

chore(deps): bump actions/setup-go from 4 to 5
@0xHueristiq 0xHueristiq self-assigned this Oct 20, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

TLSClientConfig: &tls.Config{
InsecureSkipVerify: true, //nolint:gosec // Intended
InsecureSkipVerify: true,

Check failure

Code scanning / CodeQL

Disabled TLS certificate check High

InsecureSkipVerify should not be used in production code.

Copilot Autofix AI 26 days ago

To fix the problem, we need to ensure that the TLS certificate verification is enabled. This involves setting InsecureSkipVerify to false or removing the InsecureSkipVerify field altogether, as the default value is false. Additionally, we should ensure that the application is configured with the correct certificates to allow for proper verification.

  • General Fix: Ensure that the TLS configuration does not disable certificate verification.
  • Detailed Fix: In the file pkg/xcrawl3r/xcrawl3r.go, modify the TLSClientConfig to remove or set InsecureSkipVerify to false.
  • Specific Changes: Update lines 274-277 to remove the InsecureSkipVerify field or set it to false.
Suggested changeset 1
pkg/xcrawl3r/xcrawl3r.go

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/pkg/xcrawl3r/xcrawl3r.go b/pkg/xcrawl3r/xcrawl3r.go
--- a/pkg/xcrawl3r/xcrawl3r.go
+++ b/pkg/xcrawl3r/xcrawl3r.go
@@ -274,3 +274,2 @@
 		TLSClientConfig: &tls.Config{
-			InsecureSkipVerify: true,
 			Renegotiation:      tls.RenegotiateOnceAsClient,
EOF
@@ -274,3 +274,2 @@
TLSClientConfig: &tls.Config{
InsecureSkipVerify: true,
Renegotiation: tls.RenegotiateOnceAsClient,
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@enenumxela enenumxela merged commit 9a5236b into main Oct 20, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants